Skip to content

feat: support multiple payment gateway#21374

Merged
ijitendrasap merged 20 commits intodevelopfrom
multi-payment-gateway
Apr 27, 2026
Merged

feat: support multiple payment gateway#21374
ijitendrasap merged 20 commits intodevelopfrom
multi-payment-gateway

Conversation

@ijitendrasap
Copy link
Copy Markdown
Contributor

No description provided.

@ijitendrasap ijitendrasap requested a review from a team as a code owner April 15, 2026 11:07
@github-actions github-actions Bot marked this pull request as draft April 15, 2026 11:07
@ijitendrasap ijitendrasap marked this pull request as ready for review April 15, 2026 11:08
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 15, 2026

spartacus    Run #52915

Run Properties:  status check passed Passed #52915  •  git commit 8ae074d214 ℹ️: Merge 0a7ebfdfb2ed6774936d2709689169393dc72349 into c73c2287fe774c14a457c7078faa...
Project spartacus
Branch Review multi-payment-gateway
Run status status check passed Passed #52915
Run duration 04m 16s
Commit git commit 8ae074d214 ℹ️: Merge 0a7ebfdfb2ed6774936d2709689169393dc72349 into c73c2287fe774c14a457c7078faa...
Committer ijitendrasap
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
View all changes introduced in this branch ↗︎

@github-actions github-actions Bot marked this pull request as draft April 16, 2026 11:54
@ijitendrasap ijitendrasap marked this pull request as ready for review April 20, 2026 07:12
@github-actions github-actions Bot marked this pull request as draft April 20, 2026 11:19
@ijitendrasap ijitendrasap marked this pull request as ready for review April 20, 2026 11:26
@github-actions github-actions Bot marked this pull request as draft April 21, 2026 15:19
@ijitendrasap ijitendrasap marked this pull request as ready for review April 21, 2026 15:19
Copy link
Copy Markdown
Contributor

@Matejk00 Matejk00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this stays backward compatible. Changing APIs from a single OpfActiveConfiguration to OpfActiveConfiguration[] (and similar signature changes like activeConfiguration → activeConfigurations) is a breaking change for existing consumers.

We’d like this to be strictly backward compatible and preserve the exact old behavior when a single OpfActiveConfiguration is provided. Only when an array is passed should we execute the new multi-config logic.

Concretely, please add explicit branching everywhere the new logic is used, e.g.:

@Input() activeConfiguration: OpfActiveConfiguration | OpfActiveConfiguration[];
if (Array.isArray(this.activeConfiguration)) {
  // here TS knows: OpfActiveConfiguration[]
  // run NEW multi-config logic
} else {
  // here TS knows: OpfActiveConfiguration
  // keep OLD single-config logic
}

Same principle for any helpers/services that changed from activeConfiguration → activeConfigurations: keep the old single-config path intact, and only use the new code when an array is actually provided.

@github-actions github-actions Bot marked this pull request as draft April 23, 2026 12:10
@ijitendrasap ijitendrasap marked this pull request as ready for review April 23, 2026 12:46
@github-actions
Copy link
Copy Markdown
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft April 23, 2026 16:47
@ijitendrasap ijitendrasap marked this pull request as ready for review April 23, 2026 16:48
@github-actions github-actions Bot marked this pull request as draft April 23, 2026 16:48
@ijitendrasap ijitendrasap marked this pull request as ready for review April 24, 2026 05:03
@github-actions github-actions Bot marked this pull request as draft April 27, 2026 03:53
@ijitendrasap ijitendrasap marked this pull request as ready for review April 27, 2026 03:59
@github-actions github-actions Bot marked this pull request as draft April 27, 2026 07:04
@ijitendrasap ijitendrasap marked this pull request as ready for review April 27, 2026 07:51
@github-actions github-actions Bot marked this pull request as draft April 27, 2026 08:51
@ijitendrasap ijitendrasap marked this pull request as ready for review April 27, 2026 08:51
@github-actions
Copy link
Copy Markdown
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft April 27, 2026 09:07
@ijitendrasap ijitendrasap marked this pull request as ready for review April 27, 2026 09:07
@github-actions github-actions Bot marked this pull request as draft April 27, 2026 09:28
@ijitendrasap ijitendrasap marked this pull request as ready for review April 27, 2026 14:52
@ijitendrasap ijitendrasap merged commit 9ff2cda into develop Apr 27, 2026
38 checks passed
@ijitendrasap ijitendrasap deleted the multi-payment-gateway branch April 27, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants